Feature: Dynamic Plugins #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when running npm install against the packages, these missing definitions got added automatically.
To use a remote docker instance I am using SyncThing to get the binary packages pre-compiled for linux. The .stfolder should stay with the repo in order to avoid Syncthing to break.
This includes documentation in ./docs/plugins.md on the way the plugins work. Note: I am not happy about this implementation. It is done in order to have a working system but down-the-line I am reasonably certain that this will cause issues. Currently the dynamic plugins are processed basically separately from the regular plugins and that makes a lot of things difficult. The, imo, correct alternative to this implementation is a complex refactoring that loads all plugins using the same system. However, that may have a performance impact if done poorly. Due to time-constraints I am going with this code that contains code duplication. I am sorry - orz.
martinheidegger
force-pushed
the
dynamic-plugins
branch
from
121b9b6
to
45806c1
Compare
…date-resource by some plugins
…or each plugin to load their own version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamic plugins to mycloud and removes in-house-plugins that should be loaded dynamically.
Documentation on the setup and development process of dynamic plugins can be found in the documentation.
Closes #37