New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix multi-pane feature #824
base: master
Are you sure you want to change the base?
Conversation
Things I have implemented so far:
Things I am also implementing but not going to be included in this PR:
|
…ions for pane option
This reverts commit 2194ebc
51a6e4d
to
b23da6f
Compare
resolved merge conflicts with tradingview's master branch |
This PR still merges easily to the master, qwpto@7efe1bc it would be a great feature to have instead of needing to maintain a fork of the project to get it. @ntf how did you generate the inlined code for the jsfiddle? |
There is a conflict with the latest version. I hope you can solve it |
Does this feature still in the loop for future release ? |
Here is an updated fork people can reference if they'd like: https://github.com/rwitzlib/lightweight-charts |
@rwitzlib Can you explain to me how can I add another pane to the chart with your fork ? |
Of course, I left a comment here: #50 (comment) so its a bit easier for people to see |
Type of PR: enhancement
PR checklist:
Overview of change:
This is base on the pane widget and pane separator feature previously implemented in 22c6b03.
Is there anything you'd like reviewers to focus on?
API design. New API added so far (To be finalized)
Things I have implemented so far:
ChartApi#removePane(index: number)
so that you can remove a pane (and series on it) programmatically.ChartApi#swapPane(first: number, second: number)
for swapping the positions of the two pane.ChartApi#getPaneElements()
for getting container elements to each pane. (I need the container to draw legends to each pane)Things I am also implementing but not going to be included in this PR:
Demo here (It maybe outdated): https://jsfiddle.net/adrianntf/6qea5ytv/2/
You can use below command to install my version to your project locally:
yarn add git+https://github.com/ntf/lightweight-charts.git
or
npm install git+https://github.com/ntf/lightweight-charts.git
You should not use this directly in your production environment. However, you may review my code and merge into your own folk of the project.