Fix Main Actor warnings #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinChangCC
requested review from
caioremedio,
havocked,
eugrdn and
Prajakta-Aher-TR
…in-actor-warnings # Conflicts: # SectionKit/Tests/SectionController/SectionFlowDelegate/BaseFlowLayoutSectionControllerSectionFlowDelegateTests.swift # SectionKit/Tests/SectionController/SectionFlowDelegate/BaseFlowLayoutSectionFlowDelegateTests.swift # SectionKit/Tests/SectionController/SectionFlowDelegate/ProtocolDefaultValuesSectionFlowDelegateTests.swift
havocked
approved these changes
Apr 11, 2024
| guard Self.self === BaseCollectionViewAdapterUICollectionViewDataSourceTests.self else { return } | ||
| throw XCTSkip("Tests from base class are skipped") | ||
| } | ||
|
|
||
| internal func createCollectionView( | ||
| func createCollectionView( |
There was a problem hiding this comment.
Shoudn't @mainactor be present here?
Base automatically changed from
Foundation-set-up-for-compositional-layout
to
Compositional-layout-support
April 16, 2024 22:12
# Conflicts: # SectionKit.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XCTestCase is not a Main Actor, inheriting it and adding the MainActor property wrapper will cause the error after Swift 6