CubeCL first iteration #1756
Merged
CubeCL first iteration #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
- Coverage 86.61% 86.41% -0.21%
==========================================
Files 700 734 +34
Lines 83423 85575 +2152
==========================================
+ Hits 72258 73947 +1689
- Misses 11165 11628 +463 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
May 15, 2024
| /// Derive macro for the module. | ||
| #[proc_macro_attribute] | ||
| pub fn cube(attr: TokenStream, tokens: TokenStream) -> TokenStream { | ||
| let args = parse_macro_input!(attr with Punctuated::<Meta, syn::Token![,]>::parse_terminated); |
|
|
||
| pub struct CubeContext { | ||
| pub root: Rc<RefCell<Scope>>, | ||
| pub scope: Rc<RefCell<Scope>>, |
There was a problem hiding this comment.
Do we need to put the scope in a cell (Rc) if yes where do we clone it?
| #[derive(new, Clone, Debug)] | ||
| /// Reference to a JIT variable | ||
| /// It's the expand element that is actually kept in the variable pool | ||
| pub struct ExpandElement { |
There was a problem hiding this comment.
I don't like the name, maybe CubeVariable would be better?
crates/burn-cube/src/element/int.rs
Outdated
Comment on lines
8
to
14
| + std::cmp::PartialOrd | ||
| + std::ops::Add<Output = Self> | ||
| + std::ops::Sub<Output = Self> | ||
| + std::ops::Mul<Output = Self> | ||
| + std::ops::Div<Output = Self> | ||
| + std::ops::AddAssign | ||
| + std::ops::Rem<Output = Self> |
There was a problem hiding this comment.
Could all of those be moved to the Numeric trait ?
Comment on lines
5
to
14
| pub trait RuntimeType: CubeType<ExpandType = ExpandElement> { | ||
| type Primitive; | ||
| fn val(&self) -> Self::Primitive; | ||
| fn into_elem() -> Elem; | ||
| fn from_expand(context: &mut CubeContext, val: ExpandElement) -> ExpandElement { | ||
| let new_var = context.create_local(Item::Scalar(<Self as RuntimeType>::into_elem())); | ||
| assign::expand(context, val, new_var.clone()); | ||
| new_var | ||
| } | ||
| } |
There was a problem hiding this comment.
We should add documentation on that trait, since it's so central.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1665
Since the goal of CubeCL is to rewrite all our JIT kernels with a readable rusty syntax, I started by supporting all the basic syntax to parse it into to the JIT intermediate representation, and figured out an enjoyable type system for element types, with support for easy casting. To look at examples, navigate to
crates/burn-cube/testswhere kernels marked with#[cube]are tested against theirgpu!macro counterparts.Next steps: