Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a count to Copen to set quickfix height #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a count to Copen to set quickfix height #207

wants to merge 1 commit into from

Conversation

shym
Copy link
Contributor

@shym shym commented Jul 22, 2017

Proposal of a PR to close #177.
If you agree with this solution, I could mention the option in the documentation.

@shym shym mentioned this pull request Jul 22, 2017
Open
@tpope
Copy link
Owner

tpope commented Jul 26, 2017

I don't think I'm on board with the whole dispatch_temporary_quickfix_height shenanigans.

@shym
Copy link
Contributor Author

shym commented Aug 3, 2017

Thinking about it, I’m not so sure either.
So I rewrote this PR to what I originally had in mind, when I opened #177.
This does change a current behaviour for users who set dispatch_quickfix_height and expect Copen to use this value, but this makes it closer to copen, using 10 lines unless you explicitly mention the height.

@shym shym mentioned this pull request Aug 3, 2017
Merged
@shym
Copy link
Contributor Author

shym commented Oct 25, 2017

@tpope did you have time to look that PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a height option to Copen
2 participants
@shym @tpope