Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a height option to Copen #177

Open
shym opened this issue Jul 17, 2016 · 4 comments · May be fixed by #207
Open

Add a height option to Copen #177

shym opened this issue Jul 17, 2016 · 4 comments · May be fixed by #207

Comments

@shym
Copy link
Contributor

shym commented Jul 17, 2016

copen command can take a height option for the quickfix window and, as far as I can tell, that height is preserved until the next explicit invocation of copen.
Could Copen provide the same option and behaviour?

By the way, for consistency, it would be great for that height to be used also for tmux splits.
@eremite
Copy link

eremite commented Jun 23, 2017 

let g:dispatch_quickfix_height=20
let g:dispatch_tmux_height=20

That may not help you, but it helped me.

@tpope
Copy link
Owner

tpope commented Jun 23, 2017

Circling back to the original post, I'd entertain a PR that added -count to :Copen.

tpope added a commit that referenced this issue Jun 23, 2017
@tpope
Default tmux height to quickfix height
ca10dc1 
Must not have been paying close attention when merging the original
changeset because forcing users to set both options is stupid.

References #177
@tpope
Copy link
Owner

tpope commented Jun 23, 2017

By the way I'm changing it so you only have to set g:dispatch_quickfix_height, because forcing you to set both options to the same value is a waste of everyone's time.

@shym
Copy link
Contributor Author

shym commented Jul 1, 2017 •
edited

When I opened this issue, those configuration variables were not available yet, so I proposed something as close as possible to the standard vim command. But I’ve been using the configuration variables since they were merged in. It’s probably handier to have variables and using copen to adjust the size when needed, by the way.

Edit: after using for a few days the patch in #207, I find it a nice complement to the setting.

@shym shym linked a pull request Jul 22, 2017 that will close this issue
Open
@tpope tpope mentioned this issue Jun 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a count to Copen to set quickfix height shym/vim-dispatch
3 participants
@tpope @eremite @shym