Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm2_hash: Change default hashing alg from sha1 to sha256 #3342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idesai
Copy link
Member

@idesai idesai commented Jan 25, 2024

Fixes #3340

Signed-off-by: Imran Desai <imran.desai@intel.com>
@idesai idesai added this to the 6.0.0 milestone Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (98ca6ba) 74.38% compared to head (58d0129) 74.30%.
Report is 1 commits behind head on master.

Files Patch % Lines
tools/tpm2_changeauth.c 35.71% 9 Missing ⚠️
tools/tpm2_import.c 35.71% 9 Missing ⚠️
tools/misc/tpm2_encodeobject.c 44.44% 5 Missing ⚠️
lib/tpm2.c 60.00% 4 Missing ⚠️
tools/tpm2_createak.c 25.00% 3 Missing ⚠️
tools/tpm2_createek.c 40.00% 3 Missing ⚠️
tools/tpm2_loadexternal.c 40.00% 3 Missing ⚠️
lib/tpm2_util.c 60.00% 2 Missing ⚠️
tools/tpm2_create.c 90.90% 1 Missing ⚠️
tools/tpm2_load.c 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3342      +/-   ##
==========================================
- Coverage   74.38%   74.30%   -0.09%     
==========================================
  Files         173      173              
  Lines       23673    23754      +81     
==========================================
+ Hits        17610    17651      +41     
- Misses       6063     6103      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is SHA1 the default hashing algorithm in tpm2-tools?
1 participant