Revert "session: do not delete on flush" #3326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b654a56. Signed-off-by: Bill Roberts <bill.c.roberts+gh@gmail.com>
williamcroberts
force-pushed
the
revert-revert-session-delete
branch
from
2de89fa
to
469a686
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3326 +/- ##
==========================================
- Coverage 76.54% 76.53% -0.01%
==========================================
Files 173 173
Lines 23673 23677 +4
==========================================
+ Hits 18120 18121 +1
- Misses 5553 5556 +3 ☔ View full report in Codecov by Sentry. |
JuergenReppSIT
approved these changes
Dec 21, 2023
|
Could you rebase this on latest master, so we can get the green checkmark for BSD ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b654a56.