Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced Directions #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commits on Sep 1, 2016

  1. Forced Directions

    I want to start off by saying this is my first time suggesting a file edit to a repository I'm not involved in, and that I'm relatively new to programming as an occupation, so please do let me know if you think I've done anything in a 'newbie' way. I'm very happy to be corrected and learn.
    
    Thank you so much for writing this Javascript library, it's been really great. However if you want the slide show to cover a client's whole screen, a problem can crop up with parts of the photo disproportionately outside of its border. A laptop screen for example can wind up expanding the photo to fit the width, and then having a chunk of the picture outside the border vertically. This means when your kenburns.js gets to work the vertical movements will be much faster than the horizontal movements.
    
    The fix I've gone for is adding the option to force movements to be either wholly vertical or horizontal. If you want to use that option you just set the `forceDirection` variable to either 'horizontal' or 'vertical' when initialising the Plugin on an element.
    YetiFace committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    c21f702 View commit details
    Browse the repository at this point in the history