New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: optimize query utils #1610

Merged

abondar merged 2 commits into tortoise:develop from waketzheng:refactor-query.utils-to-fix-todos

May 14, 2024

Contributor

waketzheng commented May 11, 2024

Description

Motivation and Context

fix todos

How Has This Been Tested?

make ci

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

waketzheng added 2 commits

May 11, 2024 22:40


          refactor: optimize query utils

e020fef


          Use position argument instead of kwargs

49cf8f1

coveralls commented May 11, 2024

Pull Request Test Coverage Report for Build 9044995601

Details

22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 87.946%

Totals
Change from base Build 9028420328:	0.01%
Covered Lines:	5775
Relevant Lines:	6470

💛 - Coveralls

abondar approved these changes

View reviewed changes

abondar merged commit d7c59dc into tortoise:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment