Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate version info #1608

Merged
merged 6 commits into from May 14, 2024

Conversation

waketzheng
Copy link
Contributor

Description

Both pyproject.toml and tortoise/__init__.py have version info (current is 0.20.1)

There are two ways to make it only one:

As we do not need to support python3.7 and importlib.metadata is much more simple, so I use it in tortoise/__init__.py, and introduce new testcase tests/test_version.py

Motivation and Context

Note: At local development environment, when version in pyproject.toml was changed, python -c 'from tortoise import __version__;print(__version__)' will not print the new one, unless you run make deps again.

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tests/test_version.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9029021265

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 87.934%

Totals Coverage Status
Change from base Build 9028420328: 0.002%
Covered Lines: 5771
Relevant Lines: 6467

💛 - Coveralls

@abondar abondar merged commit 9053fa7 into tortoise:develop May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants