Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
pyproject.toml
andtortoise/__init__.py
have version info (current is 0.20.1)There are two ways to make it only one:
importlib.metadata
As we do not need to support python3.7 and
importlib.metadata
is much more simple, so I use it intortoise/__init__.py
, and introduce new testcasetests/test_version.py
Motivation and Context
Note: At local development environment, when version in pyproject.toml was changed,
python -c 'from tortoise import __version__;print(__version__)'
will not print the new one, unless you runmake deps
again.How Has This Been Tested?
make ci
Checklist: