New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix models check method #1597

Closed

vlakius wants to merge 3 commits into tortoise:develop from vlakius:fix-models-check-method

vlakius commented Apr 30, 2024

Description

Renamed classmethod check to _check

Motivation and Context

How Has This Been Tested?

I performed all the tests as well as manual tests

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

vlakius added 3 commits

April 30, 2024 08:12


          renamed check to _check

7c61b68


          Updated Changelog

21a91ca


          Update contributors

8083d95

coveralls commented Apr 30, 2024

Pull Request Test Coverage Report for Build 8890195297

Details

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.934%

Totals
Change from base Build 8879569614:	0.0%
Covered Lines:	5771
Relevant Lines:	6467

💛 - Coveralls

Member

abondar commented May 7, 2024

Hi

Please make more elaborate description on CHANGELOG, with breaking section, as we changed part of public api here

Member

abondar commented May 14, 2024

@vlakius are you planning to update this PR?

Member

abondar commented May 22, 2024

I replicated these changes with my own commit to include this changes in 0.21.0
a5be9b6

abondar closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment