Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lint/format tool from isort/black to ruff and run unittest of examples in ci #1596

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

waketzheng
Copy link
Contributor

  1. Fully migrate to Ruff, remove black, use ruff format to make style;
  2. Auto run unittests in examples when running ci

Description

Ruff is much more faster, we can fully migrate to it as the fastapi's lint script

Motivation and Context

  1. Unittests in examples should also be run in ci
  2. Lint/format by only ruff is better than by isort+black+ruff.

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8889506316

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 87.929%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/contrib/mysql/fields.py 0 1 0.0%
Totals Coverage Status
Change from base Build 8879569614: -0.005%
Covered Lines: 5768
Relevant Lines: 6464

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants