Add an optional flag to export circuit id per port #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we have HiddenServiceExportCircuitID which allows us to export the circuit id using haproxy. However, such directive is applied globally in the service. We need a way to export the circuit id only for some virtual ports. We can do that by adding an optional flag to the HiddenServicePort directive to specify that we will export the circuit id for such port. The flag in HiddenServicePort will override the one in HiddenServiceExportCircuitID, if it's not none. But it will use the protocol specified in HiddenServiceExportCircuitID, if it's otherwise.
mallidadon
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have HiddenServiceExportCircuitID which allows us to
export the circuit id using haproxy. However, such directive is applied
globally in the service. We need a way to export the circuit id only for
some virtual ports.
We can do that by adding an optional flag to the HiddenServicePort
directive to specify that we will export the circuit id for such port.
The flag in HiddenServicePort will override the one in
HiddenServiceExportCircuitID, if it's not none. But it will use the
protocol specified in HiddenServiceExportCircuitID, if it's otherwise.
So, the new syntax for HiddenServicePort directive will be
HiddenServicePort VIRTPORT [TARGET [EXPORT-CIRCUIT-ID-PROTOCOL]]