Bug21065 035 #2053
Open
Bug21065 035 #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of a fix for 20165: we will use this information to see whether we can call a self-test successful.
Previously we'd treat an incoming circuit as indicating orport reachability, even if it was to an ORPort other than the one we were trying to test. Now we only treat it as indicating reachability when it is on a canonical-to-peer channel: one where the address matched our published address when the channel was made. Fixes bug introduced in 4f5192b in 0.1.0.1-rc, back when we added self-reachability tests. Closes 20165.
Pull Request Test Coverage Report for Build 9781
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.