hs-v2: Add deprecation warning for service #1962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If at least one service is configured as a version 2, a log warning is emitted once and only once. Closes #40003 Signed-off-by: David Goulet <dgoulet@torproject.org>
Pull Request Test Coverage Report for Build 9360
💛 - Coveralls |
asn-d6
reviewed
Jul 2, 2020
src/feature/rend/rendservice.c
Outdated
| @@ -731,6 +747,9 @@ rend_config_service(const config_line_t *line_, | |||
| tor_assert(options); | |||
| tor_assert(config); | |||
|
|
|||
| /* We are about to configured a version 2 service. Warn of deprecation. */ | |||
asn-d6
reviewed
Jul 2, 2020
| log_warn(LD_REND, "DEPRECATED: Onion service version 2 are deprecated. " | ||
| "Please use version 3 which is the default now. " | ||
| "Currently, version 2 is planned to be obsolete in " | ||
| "the Tor version 0.4.6 stable series."); |
There was a problem hiding this comment.
Do you think we should link to the tor-dev post or the blog post here?
There was a problem hiding this comment.
As discussed, maybe not ideal to have links hardcoded in our tor codebase as in the link then has to be a super long permalink...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If at least one service is configured as a version 2, a log warning is emitted
once and only once.
Closes #40003
Signed-off-by: David Goulet dgoulet@torproject.org