Ticket33072 042 01 #1858
Open
Ticket33072 042 01 #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #33072 Signed-off-by: David Goulet <dgoulet@torproject.org>
This also adds the support for the option meaning, if set, every uncompressed directory requests will be served by the dirauth with a 503 error code. Signed-off-by: David Goulet <dgoulet@torproject.org>
Pull Request Test Coverage Report for Build 8670
💛 - Coveralls |
teor2345
reviewed
Apr 9, 2020
| @@ -56,7 +56,7 @@ problem dependency-violation /src/core/crypto/onion_crypto.c 5 | |||
| problem dependency-violation /src/core/crypto/onion_fast.c 1 | |||
| problem dependency-violation /src/core/crypto/onion_tap.c 3 | |||
| problem dependency-violation /src/core/crypto/relay_crypto.c 9 | |||
| problem file-size /src/core/mainloop/connection.c 5569 | |||
| problem file-size /src/core/mainloop/connection.c 5694 | |||
There was a problem hiding this comment.
Wow, you shouldn't need to fix practracker on 0.4.2 or 0.4.3.
I have removed check-best-practices from check-local on all maint and release branches. So practracker only runs by default on master.
teor2345
suggested changes
Apr 9, 2020
Comment on lines
+3227
to
+3230
| if (c_method != NO_METHOD) { | ||
| /* Always answer compressed request. */ | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This code is missing in 0.4.3, but present in 0.4.2 and master.
Did you forget to delete it in 0.4.2 and master?
Comment on lines
+3193
to
+3197
| * If we are a directory authority, false is returned (indicating that we | ||
| * should answer the request) if one of these conditions is met: | ||
| * - Connection is from a known relay (address is looked up). | ||
| * - AuthDirRejectRequestsUnderLoad is set to 0. | ||
| * - Compression is being used for the request (looking at c_method). |
There was a problem hiding this comment.
This comment doesn't match what the function does in 0.4.3.
teor2345
reviewed
Apr 9, 2020
| @@ -0,0 +1,4 @@ | |||
| o Minor bugfix (directory authority): | |||
| - Always allow compressed directory requests and introduce option | |||
There was a problem hiding this comment.
Oh, the changes file is out of sync as well.
We let AuthDirRejectRequestsUnderLoad and the bandwidth buckets decide about compressed requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.