Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: Type SUPPORTED_METHODS so it can be overridden. #3354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

web: Type SUPPORTED_METHODS so it can be overridden. #3354

wants to merge 1 commit into from

Commits on Dec 8, 2023

  1. web: Type SUPPORTED_METHODS so it can be overridden. 

    Its default type is `Tuple[str, str, str, str, str, str, str]`, which
can only be overridden by a tuple of the exact same length.  Which is
not terribly useful for its stated purpose.

Type it as a `Collection[str]`, which should support folks overriding
it as any number of reasonable things, as it is only used by way of
`if request.method not in self.SUPPORTED_METHODS`.
    @alexmv
    alexmv committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3230e95 View commit details
    Browse the repository at this point in the history