Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocketClientConnection parameter #3308

Merged

Conversation

TnTomato
Copy link
Contributor

Hi,

This is my first time making PR to this repo. Wish this will help.

While developing libs based on Tornado, I found a mutable default argument value in WebSocketClientConnection.__init__.

subprotocols: Optional[List[str]] = []

I think it's better to set the default argument value to None to prevent from some unpredictable problems.

@bdarnell
Copy link
Member

bdarnell commented Sep 2, 2023

Thanks!

@bdarnell bdarnell merged commit a48d634 into tornadoweb:master Sep 2, 2023
11 checks passed
@TnTomato TnTomato deleted the fix-WebSocketClientConnection-parameter branch September 4, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants