Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 3 more options #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added 3 more options #133

wants to merge 1 commit into from

Conversation

muellmatto
Copy link

  1. default image rendition
  2. skip bleaching
  3. dont wrap images in anchor tags

@zerolab
Copy link
Member

zerolab commented Nov 9, 2023

@muellmatto thank you for this.
Two things:

  1. Drop the unsafe_html setting/logic. I'd rather not provide the gun for people to shoot their feet with
  2. Can you add some tests for the default image rendition, and skipping anchors around images?

@muellmatto
Copy link
Author

Hi, thank you for your feedback.
I agree with your first point, i was too lazy to configure allowed_tags.
I will try to provide some tests soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants