-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add search operator and fields arguments #321
base: main
Are you sure you want to change the base?
Conversation
c3397c7
to
ca511f9
Compare
ca511f9
to
33e8135
Compare
8fabb87
to
3bf9d79
Compare
@zerolab what documentation are you looking for here? I added some inline the graphql type definitions so it shows up in graphiql. |
3bf9d79
to
6c79caf
Compare
I was thinking developer docs (e.g. https://wagtail-grapple.readthedocs.io/en/latest/general-usage/model-types.html) so it is not buried in code |
Are we creating documentation for consumers of of grapple or for grapple devs? We do not have any docs on the shared GraphQL Structures that this impacts and none of the enable_* options to the QuerySetList constructor or PaginatedQuerySet are exposed via the Decorators. I would propose the we create a new issue to document the structures... I feel like we need to document structures and how they are related to the decorators and GraphqlTypes... My understanding is that the structures are effectively base types for all of the generated GraphQL Types... so documenting those should probably go into GraphQL types. The new section of docs feels like a fairly large task on it's own... How do you feel about deferring this documentation effort to a separate task.... I found the current docs pretty intimidating as a new user and quite confusing... There is a lot of assumption that I would know what a field was and what the plural, singular, and paginated modified mean... |
We want docs for both consumers and devs. For example, as an implementer/user I would like to know that I can change the search operator Now, my previous comment was me cheekily hoping to get that started here 🙈 |
Alright I'll work on tests next week. :) |
allow for more specific search queries by specifying the search_operator and search_fields.
6c79caf
to
54ef10e
Compare
@dopry are you still keen to pursue this? We need some test, then I can do a full review/local testing pass and get it in |
@zerolab I am, but I'm just getting back to work after summer break. It'll take me a few weeks at least to catch up on client work before I can take on any OSS work. |
still on my radar, I'm wrapping up some work on django-oauth-toolkit that is a higher priority for me, so maybe a week or two out still. |
Add parameters for search_operator and search_fields when search is enabled on a query.