Replaced svg with codicon to support other Product icon themes and Throw ball with mouse command palette error #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraneshBalasubramaniam
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 16.88% 16.90% +0.02%
==========================================
Files 22 22
Lines 1161 1165 +4
Branches 158 158
==========================================
+ Hits 196 197 +1
- Misses 959 962 +3
Partials 6 6
☔ View full report in Codecov by Sentry. |
PraneshBalasubramaniam
force-pushed
the
master
branch
from
01ce431
to
10b9ce9
Compare
PraneshBalasubramaniam
changed the title
PraneshBalasubramaniam
force-pushed
the
master
branch
from
10b9ce9
to
ab5a814
Compare
…alatte tonybaloney#375 - removed activationEvents as VS Code will generate these automatically
PraneshBalasubramaniam
force-pushed
the
master
branch
from
ab5a814
to
dc9b9e3
Compare
tonybaloney
requested changes
Oct 12, 2023
|
Thanks for the PR. I'll review both changes but in future it's generally preferred to have 1 PR per change |
ok , Thanks for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#480 Replaced svg with codicon to support other Product icon themes
#375 'Throw ball with mouse' command palette error
Please let me know if there are any issues.