Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default keybinding from C-c a to C-c ; #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Trevoke
Copy link
Contributor

@Trevoke Trevoke commented Sep 20, 2017

This is a simple, mostly configuration-based PR that addresses #229 and brings alchemist into the rank of the packages that respect emacs conventions.

There's probably more things I need to do here, like regenerate the PDF and such, but I'm not sure how to do it.

I also know that just merging in this PR is no easy feat, but if we don't open it, we'll NEVER merge it :)

@tonini
Copy link
Owner

tonini commented Sep 21, 2017

@Trevoke Thanks a lot mate. 💚

This is something we started to discuss a while back ago but my daily life got me quite busy in the last time. So I'm glad you made the first step. 👍

I'll have a look on in today and also try to add the missing parts where we have to change as well.

Thanks.

@Trevoke
Copy link
Contributor Author

Trevoke commented Sep 25, 2017

I can also do more of the work if you want, just point me in the right direction :)

@tonini
Copy link
Owner

tonini commented Oct 30, 2017

@Trevoke I guess when we merge this one we should soon release another version. But I think it would be a good step in the right direction to refine these keybindings.

Currently I think the Alchemist-Server needs to be redone with https://github.com/msaraiva/elixir_sense

@Trevoke do you think you could have a look at https://github.com/msaraiva/elixir_sense ? :)

@Trevoke
Copy link
Contributor Author

Trevoke commented Oct 30, 2017 via email

@dsdshcym
Copy link

Currently I think the Alchemist-Server needs to be redone with https://github.com/msaraiva/elixir_sense

Any updates on this?

@mdbergmann
Copy link

Please merge this PR.
"C-c a" causes some trouble: #354
However, there might still be a problem with configuring the default keybinding.

@kentbull
Copy link

@mdbergmann and @Trevoke this issue seems like a good candidate for testing our deployment workflow for resurrecting this project. It's simple and easy to grok. Have either of you had any thoughts on this issue in the intervening months since its inception?

@kentbull
Copy link

@dsdshcym yes, the project is forked and moved here: https://github.com/elixir-lsp/elixir_sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants