Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/goto-definition-prompts-for-empty-scope #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature/goto-definition-prompts-for-empty-scope #289

wants to merge 1 commit into from

Conversation

kisp
Copy link

@kisp kisp commented Feb 13, 2017

Hi,

I have a small change here for alchemist-goto-definition-at-point. If no scope can be found, i.e. if (alchemist-scope-expression) returns "", the user is prompted in the minibuffer.

The rationale for this is that sometimes I would like to jump to a definition that is not written somewhere in the current buffer. So instead of writing this into the buffer in order to be able to jump there, I would prefer to write it into the minibuffer.

Could you help to make this pull request even nicer?

  • please comment on how I changed alchemist-goto--open-definition. Should I do something differently?
  • Is there a way to ask for the definition in the minibuffer with completion support? I think this would be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant