-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/webpack 5 support #102
base: develop
Are you sure you want to change the base?
Conversation
…ik#99 - vulnerabilities
Oh my god! That is a horrific amount of work. Great, good work 👏 As this is way beyond standard update I would need to sit down and test it out on a few different projects. I will do this as soon as it will be possible 😄 Thanks! |
@jedrzejchalubek it works to the point where the scaffolding from tonik/cli comes in. It references old packages (e.g. |
@niklasp Yup, fully understanding! However, I cannot give you any estimates as I have mentioned in #94 we do not focus on WP work lately About, |
@jedrzejchalubek Yes I could totally do that, however if i would add a PR in tonik/cli, the different versions would not work together anymore unless we would add a version check? |
@niklasp Not sure what do you mean by "different versions", but there is no need for checking versions of I will take care of proper versions in composer.json file when publishing new releases of both repositories |
@jedrzejchalubek I managed to test with composer local cli repo on develop branch. Was successful (as far as I could tell) for all scaffolding (vue/bulma/bootstrap/foundation). Happy to hear back from you
we all need a WordPress theme at sometime, even if our company does not :) |
Now works with develop branch in tonik/cli