Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/webpack 5 support #102

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Conversation

niklasp
Copy link

@niklasp niklasp commented Feb 4, 2021

Now works with develop branch in tonik/cli

@jedrzejchalubek
Copy link
Collaborator

jedrzejchalubek commented Feb 4, 2021

Oh my god! That is a horrific amount of work. Great, good work 👏

As this is way beyond standard update I would need to sit down and test it out on a few different projects. I will do this as soon as it will be possible 😄

Thanks!

@niklasp
Copy link
Author

niklasp commented Feb 4, 2021

@jedrzejchalubek it works to the point where the scaffolding from tonik/cli comes in. It references old packages (e.g. bootstrap-sass instead of bootstrap and the build process fails. Would be nice to get some feedback on that as soon as possible. Because I will have to build my own starter instead, but thought it would be nice to build upon your great work. But the way it currently is it is not usable for our projects with outdated packages and vulnerabilities

@jedrzejchalubek
Copy link
Collaborator

@niklasp Yup, fully understanding! However, I cannot give you any estimates as I have mentioned in #94 we do not focus on WP work lately

About, tonik/cli. It defines package names inside its scaffolding presets in here: https://github.com/tonik/cli/tree/develop/src/CLI/Scaffolding/Presets For example Bootstrap preset. It is only a matter of changing names inside tonik/cli repository 😄

@niklasp
Copy link
Author

niklasp commented Feb 4, 2021

@jedrzejchalubek Yes I could totally do that, however if i would add a PR in tonik/cli, the different versions would not work together anymore unless we would add a version check?

@jedrzejchalubek
Copy link
Collaborator

@niklasp Not sure what do you mean by "different versions", but there is no need for checking versions of tonik/theme and tonik/cli programmatically. This will be handled by semantic versioning when publishing new releases.

I will take care of proper versions in composer.json file when publishing new releases of both repositories

@niklasp
Copy link
Author

niklasp commented Feb 4, 2021

@jedrzejchalubek I managed to test with composer local cli repo on develop branch. Was successful (as far as I could tell) for all scaffolding (vue/bulma/bootstrap/foundation). Happy to hear back from you

we do not focus on WP work lately

we all need a WordPress theme at sometime, even if our company does not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants