Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copied documentation #2928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RageKnify
Copy link

Motivation

Noticed a mistake in the span_enabled! documentation, it was copied over from event_enabled!

Solution

Fix the documentation

Copy link
Contributor

@kaffarell kaffarell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Although we could probably fix this directly on the v0.1.x branch!

@RageKnify RageKnify changed the base branch from master to v0.1.x May 21, 2024 19:53
@RageKnify RageKnify requested a review from yaahc as a code owner May 21, 2024 19:53
@RageKnify RageKnify changed the base branch from v0.1.x to master May 21, 2024 20:00
@RageKnify RageKnify changed the base branch from master to v0.1.x May 21, 2024 20:04
@davidbarsky
Copy link
Member

@RageKnify Thanks for the fix! Can you change the base branch to master again? We'll handle backports.

@RageKnify RageKnify changed the base branch from v0.1.x to master May 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants