-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release next (Monorepo, React 18, ..) #2403
Draft
six7
wants to merge
200
commits into
main
Choose a base branch
from
release-139
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… themes (#2745) * feat: add token format option to get exact resolved value * revert the DTCG format * feat: add logs to figure out issue * get collection id * feat: update createLocalVariables function to rename the renamed collection and mode * feat: remove un-neccessary function to improve performance
docs: startup docs revamp
fix: adds tooltip on overflowing info for theme management entries
* fix(token-listing-heading): add spacing between group heading and content * fix(downshift-input): allow truncation of values with tooltip for a full view * fix(mention-input): stack found search values * fix(rc-mentions): prevent dropdown from overflowing plugin
…cal file when created based on sets (#2760) * feat: add token format option to get exact resolved value * revert the DTCG format * logs to figure out the root cause * method to add non active theme style references * remove duplicated code * remove console logs and add local style references * fix style creation and updating --------- Co-authored-by: Jan Six <six.jan@gmail.com>
change MentionsInput height css to auto Co-authored-by: macintoshhelper <6757532+macintoshhelper@users.noreply.github.com>
fix color application
polish dropdowns mentions
remove await for duplicateTokenGroup Redux action so completeJob runs after Co-authored-by: macintoshhelper <6757532+macintoshhelper@users.noreply.github.com>
show dedicatad image to convert back to legacy
…her token fails if the referenced token comes from another set (#2784) * feat: add token format option to get exact resolved value * revert the DTCG format * feat: add logs to figure out the issue * logs for issueing * remove consoles and add resolvedValueWithReferences to token * remove console log * feat: add test case to cover multi nest token resolve
* fix: adds canReorder variant on drag button * fix: passes canReorder prop to all components using the drag button
… share name with an existing token group (#2785) * feat: add token format option to get exact resolved value * revert the DTCG format * feat: add memo variables to check if can rename or duplicate * feat: update the condition to check duplicated name * feat: add warning component * update warning content * feat: add a logic to check a group share same name as token * feat: add test case * update test cases * Update DuplicateTokenGroupModal.test.tsx * Update DuplicateTokenGroupModal.test.tsx * Update RenameTokenGroupModal.test.tsx * Update RenameTokenGroupModal.test.tsx * Update tokens.json * Update tokens.json * Update RenameTokenGroupModal.tsx --------- Co-authored-by: Jan Six <six.jan@gmail.com>
* working commit * working state * self review 1 * revert removal of sync styles * Update useTokens.test.tsx * revert async change * revert controller * add changeset * update changes to include token sets creation * fix tests * fix tests and naming * undo rename * adjust contents * extract getOrCreateVariableCollection * move local variables fetch into merge fn * fix tests * update state * move to own fn * update and add tests * update logic for renaming collections and modes * add check to not proceed if no mode exists * fix tests * fix infinite load and create styles with variables if active theme doesnt include source sets * add cypress/downloads to gitignore * add check for undefined * add clarifying comments * update to use simpler reduce * Apply suggestions from code review Co-authored-by: Celia Usero Navarro <114073780+cuserox@users.noreply.github.com> * update test naming * add note to refactor test file * update tests --------- Co-authored-by: Celia Usero Navarro <114073780+cuserox@users.noreply.github.com>
* add empty split string * Update AnnotationBuilder.tsx Accidental commit typo in this file - removed * Create many-shrimps-tan.md --------- Co-authored-by: Jan Six <six.jan@gmail.com>
* add option to apply variables or styles * adjust to just use 1 property and add option to settings * call setUI * update UI * fix tests
* feat: add token format option to get exact resolved value * revert the DTCG format * feat: create opacitiy variable * update logic to create opacity variables without percentage value * feat: add logs to figure out the issue * feat: apply variable first when try apply opacity token * remove console logs * feat: update test case * remove un-necessary code * update logic * add changeset --------- Co-authored-by: Jan Six <six.jan@gmail.com>
* change stacking diretions * move tabs * polish ui * remove unused * Revert "remove unused" This reverts commit b5ad28f. * revert linting * fix padding and alignment * dropdown widths * wrap longer names --------- Co-authored-by: Luke Finch <lukefinch@MacBook-Air-2.local> Co-authored-by: Luke Finch <lukefinch@172-12-2-54.lightspeed.sgnwmi.sbcglobal.net>
…tuck in hold on updating (#2808) * feat: add token format option to get exact resolved value * revert the DTCG format * resolve the infinite holding by removing batch
* various polish * moar polish
* feat: add token format option to get exact resolved value * revert the DTCG format * feat: add condition to check the new toggle value for shadow type * remove un-used import
fix: adds cancel and confirm options on set selection for export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains large-scale changes to the codebase