Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce lint step, fix lint errors #2164

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

six7
Copy link
Collaborator

@six7 six7 commented Aug 14, 2023

Fixes #1958

introduces a lint step, fixes existing lint errors, added a few ts ignore's to suppress lint errors for now

This pull request includes various updates to dependencies, linting, and code readability. It also adds new jobs to the GitHub Actions workflow to improve linting.

  • .github/workflows/node.js.yml: Added new job to run linting with node version 16.x in the GitHub Actions workflow, including setting up node, checking out the repository, caching node modules, installing dependencies, and running the lint command. (.github/workflows/node.js.yml)
  • package.json: Added or updated packages glob and msw as dependencies, and modified scripts in package.json for linting. (package.json)
  • src/types/StitchesCSS.ts: Updated StitchesCSS type definition in src/types/StitchesCSS.ts to include Media and Utils from the ConfigType object, with added eslint disable comments for specific type definitions. (StitchesCSS.ts)
  • jest.config.ts: Added clover reporter to Jest configuration for generating coverage reports. (Jest configuration)
  • scripts/bundle.ts: Updated the bundle function in bundle.ts to use consistent single quotes instead of double quotes for improved code readability and consistency. (bundle.ts)

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: f1181e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Introducing a lint step and fixing lint errors
  • 📌 Type of PR: Refactoring
  • Focused PR: Yes, the PR is focused on introducing a lint step and fixing lint errors.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • General suggestions: It would be beneficial to include relevant tests to ensure the linting process is working correctly and to prevent future lint errors. Additionally, consider adding a pre-commit hook to automatically run the linting process before committing changes.

  • 🤖 Code feedback:

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a lint step to CI
1 participant