Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lint step to CI #1958

Closed
six7 opened this issue Jun 16, 2023 · 0 comments · May be fixed by #2164
Closed

Add a lint step to CI #1958

six7 opened this issue Jun 16, 2023 · 0 comments · May be fixed by #2164
Assignees
@six7
Labels
dev experience

Comments

@six7
Copy link
Collaborator

six7 commented Jun 16, 2023

We currently perform linting as a git-hook. Let's introduce a lint job in our CI that runs, and fails if linting fails. This should help keep contributions safe, as users can manually skip git-hooks and we wouldn't know.
@six7 six7 self-assigned this Aug 14, 2023
@six7 six7 mentioned this issue Aug 14, 2023
Draft
@six7 six7 mentioned this issue Apr 28, 2024
Open
@six7 six7 closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@six7 six7

Labels
dev experience
Projects
Tokens Studio for Figma Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

introduce lint step, fix lint errors tokens-studio/figma-plugin
2 participants
@six7 @SamIam4Hyma