Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warning. #2318

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix compilation warning. #2318

merged 1 commit into from
May 21, 2024

Conversation

floitsch
Copy link
Member

We had the following errors:

possibly dangling reference to a temporary [-Wdangling-reference]
 537 |     for (auto name : selector.shape().names()) {
     |                                             ^

We had the following errors:
```
possibly dangling reference to a temporary [-Wdangling-reference]
 537 |     for (auto name : selector.shape().names()) {
     |                                             ^
```
@floitsch floitsch requested a review from kasperl May 17, 2024 15:05
@cla-bot cla-bot bot added the cla-signed The contributors have signed the CLA label May 17, 2024
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floitsch floitsch merged commit 129594d into master May 21, 2024
24 of 25 checks passed
@floitsch floitsch deleted the floitsch/fix-compilation-warning branch May 21, 2024 12:46
@floitsch floitsch restored the floitsch/fix-compilation-warning branch May 23, 2024 11:56
@floitsch floitsch deleted the floitsch/fix-compilation-warning branch May 31, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The contributors have signed the CLA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants