Messaging: check the class of the list wrapped by ListSlice_ #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ListSlice_ can wrap anything that implements List, not just List_. So we can't assume it's a List_.
kasperl
approved these changes
May 16, 2024
src/messaging.cc
Outdated
Comment on lines
189
to
192
| Smi* perhaps_list_class_id = list->class_id(); | ||
| if (perhaps_list_class_id != program->list_class_id()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I'd move this up to right after you fetch the list from the slice (line 182).
Suggested change
| Smi* perhaps_list_class_id = list->class_id(); | |
| if (perhaps_list_class_id != program->list_class_id()) { | |
| return false; | |
| } | |
| // We currently do not support serializing slices of non-default lists. | |
| if (list->class_id() != program->list_class_id()) return false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListSlice_ can wrap anything that implements List, not just List_. So we can't assume it's a List_.