Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that data is not lost when on socket close. #1714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test that data is not lost when on socket close. #1714

wants to merge 2 commits into from

Conversation

erikcorry
Copy link
Member

No description provided.

@erikcorry erikcorry requested a review from floitsch July 26, 2023 08:29
@cla-bot cla-bot bot added the cla-signed The contributors have signed the CLA label Jul 26, 2023
kasperl
kasperl approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

tests/close_socket_test.toit
if keep_writing:
sleep --ms=1000
print
socket.read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why break the line here?

@kasperl
Copy link
Member

kasperl commented Feb 29, 2024

Is this still relevant, @erikcorry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperl kasperl kasperl approved these changes

@floitsch floitsch Awaiting requested review from floitsch

Assignees
No one assigned
Labels
cla-signed The contributors have signed the CLA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikcorry @kasperl