Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make captcha modular #5961

Open
wants to merge 23 commits into
base: canary
Choose a base branch
from
Open

feat: make captcha modular #5961

wants to merge 23 commits into from

Conversation

darkskygit
Copy link
Member

No description provided.

Copy link
Member Author

darkskygit commented Feb 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

@darkskygit darkskygit mentioned this pull request Feb 29, 2024
18 tasks
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 62.93436% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (f05b51a) to head (3efcd11).

Files Patch % Lines
...ages/backend/server/src/plugins/captcha/service.ts 28.57% 85 Missing ⚠️
...ckages/backend/server/src/plugins/captcha/guard.ts 89.28% 5 Missing and 1 partial ⚠️
...ges/backend/server/src/plugins/captcha/resolver.ts 82.35% 3 Missing ⚠️
packages/backend/server/src/core/auth/token.ts 93.33% 1 Missing ⚠️
...ckages/backend/server/src/core/utils/validators.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5961      +/-   ##
==========================================
- Coverage   67.57%   67.43%   -0.14%     
==========================================
  Files         584      588       +4     
  Lines       28361    28556     +195     
  Branches     2590     2591       +1     
==========================================
+ Hits        19166    19258      +92     
- Misses       8924     9028     +104     
+ Partials      271      270       -1     
Flag Coverage Δ
server-test 78.16% <62.93%> (-0.30%) ⬇️
unittest 39.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit force-pushed the darksky/captcha-modular branch 3 times, most recently from 015a230 to 637008b Compare April 24, 2024 08:22
@darkskygit darkskygit force-pushed the darksky/captcha-modular branch 2 times, most recently from 8d35fb8 to dfcb677 Compare May 15, 2024 11:03
@darkskygit darkskygit requested a review from forehalo May 15, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants