Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to jekyll #13

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

karbassi
Copy link
Member

@karbassi karbassi commented Oct 23, 2017

Fixes #14

@karbassi karbassi mentioned this pull request Oct 24, 2017
@karbassi karbassi changed the title Feature/convert to jekyll WIP: Convert to jekyll Nov 25, 2017
@donovanglover
Copy link
Contributor

Sorry I'm just now getting to this. Here's my review.

  • The Gemfile and Gemfile.lock files aren't needed. Jekyll will work just fine without them, and IMO only complicates the build process. I don't think GitHub Pages takes them into account, either.
  • Quotes are missing for the links inside apps-mobile.yml.
  • Are any of the plugins in _config.yml being used?
  • I don't have any of the files excluded in _config.yml. I believe the entire section can be safely removed.
  • The 404 page could be better. How about linking to or redirecting to the homepage?

Everything else looks fine to me. I got no errors. Some differences from the current site (not sure if you're aware):

  • The current site has the Android link removed. This version still has it.
  • Some of the items under "Community Apps" have a by tagline and other information in the live version. This version doesn't.

With the most important parts converted to Jekyll, making a new design with the site content should be a lot easier now.

These are all of the things that I noticed. Glad that you took the time to do this!

@donovanglover
Copy link
Contributor

Can you check my review? Would like to see this merged into master.

@karbassi karbassi marked this pull request as draft July 13, 2020 15:47
@karbassi karbassi changed the title WIP: Convert to jekyll Convert to jekyll Jul 13, 2020
@karbassi karbassi linked an issue Jul 13, 2020 that may be closed by this pull request
@clach04
Copy link
Contributor

clach04 commented Sep 11, 2022

@donovanglover and @karbassi what's needed to move this forward? I posted karbassi#1 which is based on this PR (and similar change for existing html version #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to Jekyll
3 participants