Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] opentitan: add i2c-target driver #3704

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

twilfredo
Copy link
Contributor

Pull Request Overview

Extends the existing I2C host driver to add support for I2C target. This is WIP, need HW testing and verification.

Testing Strategy

N/A still todo.

TODO or Help Wanted

Testing on HW.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
As per [1], make sure the clock-period-nanos is calculated correctly.
The previous calculation should truncate to 0. Which would leave to
division by 0 in the timing calculations.

[1] https://github.com/lowRISC/opentitan/blob/7b89440c36a45493e0a7c2e3f3dec71c801e5b9d/sw/device/lib/testing/i2c_testutils.c#L312

Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Oct 5, 2023
@twilfredo twilfredo marked this pull request as draft October 5, 2023 22:39
@bradjc
Copy link
Contributor

bradjc commented Oct 6, 2023

Interesting! I think we have some overlap with work @jrvanwhy is doing.

Does the OT meeting time still work for you and @alistair23? Should we revisit that timing? I think coordination on this would be useful.

@bradjc
Copy link
Contributor

bradjc commented Oct 18, 2023

Interesting! I think we have some overlap with work @jrvanwhy is doing.

Does the OT meeting time still work for you and @alistair23? Should we revisit that timing? I think coordination on this would be useful.

Ping

@jrvanwhy
Copy link
Contributor

At the moment, I am working on test infrastructure in OpenTitan that will enable us to test things like this automatically, I haven't begun work on the I2C driver itself. I don't think we need additional coordination at this time.

@lschuermann lschuermann removed their assignment Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants