Upgrade to JavaCC 5.0 #919
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahelwer
force-pushed
the
fix-javacc-windows
branch
3 times, most recently
from
56b176e
to
078b9ad
Compare
ahelwer
force-pushed
the
fix-javacc-windows
branch
2 times, most recently
from
978396c
to
96ccf59
Compare
Signed-off-by: Andrew Helwer <2n8rn1w1f@mozmail.com>
ahelwer
force-pushed
the
fix-javacc-windows
branch
from
96ccf59
to
e772af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to make parser generation work on Windows now that we added Unicode characters, since JavaCC 5.0 added the
-GRAMMAR_ENCODINGcommand line flag. This takes us from a version of JavaCC released in 2006 to one released in 2009.All the text files in this PR are auto-generated except for
customBuild.xml,tla+.jj, andParseExceptionExtended.java.There were some minor changes needed in response to breaking changes in the generated parser code:
lookingAhead; this does not change how the parser functions, as ensured by the parser test corpusspecialConstructorinParseExceptionExtended.java, mirroring change in the generated code of its parent classI also took the opportunity to remove three isolated tab characters in the
tla+.jjfile, so it now only uses spaces for indentation.One of the weirder changes in the generated parser file is that
"\n"is now emitted as"\u005cn". I have tested in a simple hello world java project and confirmed they function identically.