Wrong coverage reported for conditional such as IF-THEN-ELSE #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent sub-trees into the parent node if the parent and the sub-tree have the same costs, or the sub-tree has zero cost. Evidently, this is a wrong in the case of ITE when the true or false branch has zero cost. Essentially, the traversal of the cost model has to force reporting the children of an ITE node if the child stats are inconsistent. TODO: - Diagnose and fix test failures - Constant definitions report into a dummy CostModel, and, thus their nested ITEs show up with zero coverage (even the conditional) - Unify OpApplNodeWrapper#ite and OpApplNodeWrapper#prime - Support other conditionals such as CASE Part of Github issue #845 #845 [Bug][TLC] Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tlc2.tool.coverage.OpApplNodeWrapper.print(int, Calculate) contracts consistent sub-trees into the parent node if the parent and the sub-tree have the same costs, or the sub-tree has zero cost. Evidently, this is a wrong in the case of ITE when the true or false branch has zero cost. Essentially, the traversal of the cost model has to force reporting the children of an ITE node if the child stats are inconsistent.
TODO:
Part of Github issue #845
#845
[Bug][TLC]