Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar code improvements #383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sonar code improvements #383

wants to merge 3 commits into from

Conversation

indegro
Copy link

@indegro indegro commented Oct 24, 2019

Improvements based on sonar:
Package - tlc2.util.

  1. Added @ Override
  2. Reordered the modifiers to compy with JLS
  3. Replaced StringBuffer with StringBuilder (no ref escape, equivalent behaviour)

@lemmy
Copy link
Member

lemmy commented Oct 24, 2019

Where is this going? You can probably spend your time on more interesting issues.

@indegro
Copy link
Author

indegro commented Oct 24, 2019

Hello,

I've decided to read code and try to understand it and meanwhile do some little improvements.
If there is some minor issues that I may take, just let me know.

I would like to help the project

@indegro
Copy link
Author

indegro commented Oct 24, 2019

At the moment I have an idea to add edit support for TLA+ spec into IntelliJ Idea, cause it is the main IDE that I use at work.

@lemmy
Copy link
Member

lemmy commented Oct 24, 2019

I would assume that adding editing support to IntelliJ is the opposite of a minor issue.

#321 is well defined and enclosed from my perspective.

@indegro
Copy link
Author

indegro commented Oct 25, 2019

Thanks, let me check what I can do there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants