Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arg skip altp2m check (Qubes r4.x compatability) #1754

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

scrubbedha
Copy link

Thanks in advance @tklengyel for reviewing this PR.

This PR is directly related to your comment on the issue here: QubesOS/qubes-issues#2417 (comment)

Sorry, I meant you could add --skip-altp2m-check, then you wouldn't have to patch out-of-tree ;)

Apologies for the confusion, I thought this argument already existed in the codebase. So I did my best to add this functionality. Reviewer beware: total acolyte level C/C++ programmer here. Please, if you have the cycles and there is a more elegant way to implement this I'd be extremely grateful.

TL;DR
I'm also in the midst of recompiling qubes-vmm-xen with Flask/XSM support to see if I can get your policy working: tklengyel/xen@bfdf206

Feel the need to reiterate a very heartfelt warm "thank you" in earnest for taking the time out of your day to write those awesome crits/comments/feedback here: https://github.com/QubesOS/qubes-issues/issues/2417#issuecomment-1832972798 f for my Qubes + Drakvuf guide: https://github.com/scrubbedha/Qubes_Drakvuf/blob/master/README.md#drakvuf-black-box-binary-analysis-systemqubes-42qubes-42

@drakvuf-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

src/plugins/plugins.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants