fix(create-form.js): fix onSubmit rejection being ignored when using validationSchema #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validationSchema This commit fixes an issue that occurs when using yup validation schema and an onSubmit function that rejects. In this case, the rejection is completely ignored, because because handleSubmit has a .catch() function that assumes the error is from yup. The fix is to change the catch to a then and use both the onFulfilled and onRejected handlers, depending on whether validation failed or not.
|
It looks like the build partially failed for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue that occurs when using yup validation
schema and an
onSubmitfunction that rejects.In this case, the rejection is completely ignored, because because
handleSubmithas a.catch()function that assumes the error is from yup.The fix is to change the
catchto athenand use both the onFulfilled andonRejected handlers, depending on whether validation failed or not.