Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with rich-text when nested in jsx objects #4485

Merged
merged 15 commits into from May 1, 2024
Merged

Fix issue with rich-text when nested in jsx objects #4485

merged 15 commits into from May 1, 2024

Conversation

jeffsee55
Copy link
Member

@jeffsee55 jeffsee55 commented Apr 9, 2024 •
edited

Closes #4484

@jeffsee55 jeffsee55 requested a review from a team as a code owner April 9, 2024 03:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2024 •
edited

🦋 Changeset detected

Latest commit: 598bb59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@tinacms/mdx Patch
tinacms Patch
@tinacms/app Patch
@tinacms/graphql Patch
@tinacms/starter Patch
next-tinacms-cloudinary Patch
next-tinacms-dos Patch
next-tinacms-s3 Patch
tinacms-authjs Patch
tinacms-clerk Patch
@tinacms/cli Patch
@tinacms/vercel-previews Patch
starter-basic-iframe Patch
starter-empty Patch
e2e-next Patch
@tinacms/self-hosted-starter Patch
kitchen-sink-starter Patch
@tinacms/datalayer Patch
@tinacms/search Patch
tinacms-gitprovider-github Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeffsee55 jeffsee55 changed the title DO NOT MERGE: Add failing test to show issue with nesting mdx objects DO NOT MERGE: Add test to show issue with nesting mdx objects Apr 9, 2024
@jeffsee55 jeffsee55 changed the title DO NOT MERGE: Add test to show issue with nesting mdx objects Fix issue with rich-text when nested in jsx objects Apr 21, 2024
JackDevAU
JackDevAU previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@jeffsee55 jeffsee55 added the tagged This PR should be given a tagged release label Apr 23, 2024
@JackDevAU JackDevAU self-requested a review May 1, 2024 23:52
@JackDevAU JackDevAU merged commit 322a201 into main May 1, 2024
5 checks passed
@JackDevAU JackDevAU deleted the nested-object-mdx-issue branch May 1, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackDevAU JackDevAU JackDevAU approved these changes

Assignees
No one assigned
Labels
tagged This PR should be given a tagged release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: nested MDX objects throw parse error
2 participants
@jeffsee55 @JackDevAU