Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Create-tina-app - add starter template descriptions #4472

Merged
merged 6 commits into from Mar 26, 2024

Conversation

wicksipedia
Copy link
Member

@wicksipedia wicksipedia commented Mar 26, 2024

cc @matt-goldman @Levijj22 @kikibianc

As per request from @adamcogan (subject: Tina - Starter descriptions) - he wanted to add some descriptions to the templates in the create-tina-app cli.

I also had to pay off the following tech debt to get the code compiling (I use zsh-nvm - see https://wicksipedia.com/blog/terminal-setup) and running (since the readme was a TODO)

  • nvmrc - updated to align version with project documentation
  • gha - modified setup-node tasks to use .nvmrc file -> required workflows will need to be changed after this pr is merged (removed unused node version from matrix)
  • readme - added documentation on how to get started developing create-tina-app
  • create-tina-app - added descriptions to starter templates

Demo of changes:

CleanShot.2024-03-26.at.14.52.55.mp4

@wicksipedia wicksipedia requested a review from a team as a code owner March 26, 2024 04:33
Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 61745ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-tina-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@wicksipedia wicksipedia changed the title Create-tina-app - add starter template descriptions ✨ Create-tina-app - add starter template descriptions Mar 26, 2024
Copy link
Member

@BrookJeynes BrookJeynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wicksipedia wicksipedia merged commit 353698f into main Mar 26, 2024
5 checks passed
@wicksipedia wicksipedia deleted the align-nvmrc-with-actions branch March 26, 2024 23:03
@wicksipedia
Copy link
Member Author

required workflows will need to be changed after this pr is merged (removed unused node version from matrix)

done

CleanShot 2024-03-27 at 10 04 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants