Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rtl support for field labels and descriptions #4408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saharzal
Copy link

We are using tinacms for our site and because our native language is persian ,our content has RTL direction. but the dashboard does not look good enough when we have rtl content.
In this PR i've added rtl support for labels ,descriptions and also in value of textfields and textareas.

before these changes, admin dashboard fields looked like this:

before

here is how result looks like:

5

please tell me if you think there is better way to improve this issue.

@saharzal saharzal requested a review from a team as a code owner December 29, 2023 12:21
Copy link

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 4ba8f20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
tinacms Patch
next-tinacms-cloudinary Patch
next-tinacms-dos Patch
next-tinacms-s3 Patch
tinacms-authjs Patch
tinacms-clerk Patch
@tinacms/app Patch
@tinacms/cli Patch
@tinacms/vercel-previews Patch
starter-basic-iframe Patch
starter-empty Patch
e2e-next Patch
@tinacms/self-hosted-starter Patch
kitchen-sink-starter Patch
@tinacms/starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2023

CLA assistant check
All committers have signed the CLA.

@saharzal
Copy link
Author

@jeffsee55
@kldavis4

hello,
It's just a reminder to check whether this PR can be merged or not and if not how we can fix that.
I was wondering if I am missing a step to get a review, checked the contribution.md, I didn't see anything about the PR process.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants