Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Advanced select field #3898

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

appinteractive
Copy link

@appinteractive appinteractive commented May 3, 2023

Hey, I have improved the "select" field by using Headless UI and Tailwind. Also, does the Select offer customizations.

It's Still a Work in Progress.

Before:
https://user-images.githubusercontent.com/432828/235935528-bd07330d-1743-4bbc-83b1-053a61b66e0f.mov

After:
https://user-images.githubusercontent.com/432828/235935589-3a7b338b-57c1-4119-8ad9-7f8ae9aa731a.mov

Custom Label and Sub-Label (with font loading)
https://user-images.githubusercontent.com/432828/235935726-51e58fa5-ccaa-42b5-b6a4-74d7f187122c.mov

Custom Label Prefix
https://user-images.githubusercontent.com/432828/235935842-7312c517-1abd-4712-8f83-c8761d97d5a3.mov

I'm happy about any feedback and improvements.

After this work, I want to improve the Reference Select too.

@logan-anderson

@appinteractive appinteractive requested a review from a team as a code owner May 3, 2023 13:53
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: c4b871a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented May 3, 2023

CLA assistant check
All committers have signed the CLA.

ui: {
component: wrapFieldsWithMeta((props) => {
return (
/* @ts-ignore */
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This @ts-ignore part is annoying, it's also used on the old version, anyone with a better solution?

@appinteractive
Copy link
Author

Related to #3311

@stale
Copy link

stale bot commented Sep 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 3, 2023
@appinteractive
Copy link
Author

Help is still wanted ;)

@stale stale bot removed the wontfix This will not be worked on label Sep 3, 2023
Copy link

stale bot commented Mar 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 1, 2024
@scottgallant
Copy link
Member

Still active

@stale stale bot removed the wontfix This will not be worked on label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants