Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Modal pop-ups for Subscriptions #1756

Merged
merged 12 commits into from May 13, 2024
Merged

💄 Modal pop-ups for Subscriptions #1756

merged 12 commits into from May 13, 2024

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented May 8, 2024

General Contributing:

As per @adamcogan's email (made into #1753 ), this PR involves improving from the vanilla JS alerts when subscribing - instead we have used reactive modals. Based off of the designers wireframes this is the product.

Screenshot 2024-05-06 at 3 59 29 pm **Figure: Error subscribing modal** Screenshot 2024-05-06 at 3 59 44 pm **Figure: Success subscribing modal**

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.

@joshbermanssw joshbermanssw requested a review from a team as a code owner May 8, 2024 00:27
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:28am

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

components/forms/EmailForm.tsx Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshbermanssw joshbermanssw merged commit 89c7942 into master May 13, 2024
3 of 4 checks passed
@joshbermanssw joshbermanssw deleted the modal-popup branch May 13, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants