Move full cycle mini test to full cycle with shared params #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 145 145
Lines 5966 5966
=======================================
Hits 3893 3893
Misses 1960 1960
Partials 113 113 Continue to review full report at Codecov.
|
ryanbooz
reviewed
Jun 23, 2021
Comment on lines
+16
to
+23
| CONTAINER_NAME=timescaledb_benchmark | ||
| # setup pg with password and expose the default port. | ||
| sudo docker run -d --name $CONTAINER_NAME -p 5432:$PORT \ | ||
| -e POSTGRES_PASSWORD=$PASSWORD \ | ||
| timescale/timescaledb:latest-pg12 | ||
|
|
||
| docker start $CONTAINER_NAME | ||
| sleep 2 |
There was a problem hiding this comment.
Maybe we wrap this in a check in case we're not running this locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Our idea is to have a single command to run and share variables through different settings. As a first step we're:
Steps missing:
Shared configuration to allow us to run the same scenario in different databases.