Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation to allow pass 0 values as they represent all hosts #165

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jonatas
Copy link
Contributor

@jonatas jonatas commented May 17, 2021

It fixes #155 as we use zero values to represent all hosts. we cannot validate < 1 but < 0 to allow us to use of all hosts and get a random host.

@CLAassistant
Copy link

CLAassistant commented May 17, 2021

CLA assistant check
All committers have signed the CLA.

@Hadrien-Cornier
Copy link

Thanks for the fix, I just tested it and it seems to work

What I did :
hadrien@****:~/go_projects/src/github.com/timescale/tsbs$ git checkout 155-fix-nhosts-for-all-queries
hadrien@****:~/go_projects/src/github.com/timescale/tsbs$ make
command :
hadrien@****:~/go_projects/src/github.com/timescale/tsbs$ $GOBIN/tsbs_generate_queries --use-case="devops" --seed=123 --scale=2000 --timestamp-start="2021-03-01T00:00:00Z" --timestamp-end="2021-03-06T00:00:00Z" --queries=1000 --query-type="high-cpu-all" --format="cratedb" > /data/research/benchmark-ts-databases/crate/debug_cratedb
output :
CrateDB CPU over threshold, all hosts: 1000 points
command :
hadrien@****:~/go_projects/src/github.com/timescale/tsbs$ $GOBIN/tsbs_generate_queries --use-case="devops" --seed=123 --scale=2000 --timestamp-start="2021-03-01T00:00:00Z" --timestamp-end="2021-03-06T00:00:00Z" --queries=1000 --query-type="high-cpu-all" --format="mongo" > /data/research/benchmark-ts-databases/mongo/debug_mongodb
output :
Mongo CPU over threshold, all hosts: 1000 points

@jonatas
Copy link
Contributor Author

jonatas commented May 17, 2021

Yay! thanks for reporting @Hadrien-Cornier 🙇

@jonatas jonatas force-pushed the 155-fix-nhosts-for-all-queries branch from c7b7419 to 5caf435 Compare May 18, 2021 13:22
@jonatas jonatas force-pushed the 155-fix-nhosts-for-all-queries branch from ad7da87 to a9b57d5 Compare January 24, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate_queries.sh fails on a query type
3 participants