Fix _timescaledb_functions.remove_dropped_chunk_metadata #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
force-pushed
the
remove_dropped_chunk
branch
from
b0a3506
to
8b4b90a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6911 +/- ##
==========================================
+ Coverage 80.06% 81.68% +1.61%
==========================================
Files 190 198 +8
Lines 37181 36836 -345
Branches 9450 9634 +184
==========================================
+ Hits 29770 30088 +318
+ Misses 2997 2876 -121
+ Partials 4414 3872 -542 ☔ View full report in Codecov by Sentry. |
svenklemm
force-pushed
the
remove_dropped_chunk
branch
3 times, most recently
from
622e849
to
178e7c8
Compare
antekresic
approved these changes
May 20, 2024
akuzm
approved these changes
May 21, 2024
The removal function would only remove chunk_constraints that are part of dimension constraints. This patch changes it to remove all constraints of a chunk.
svenklemm
force-pushed
the
remove_dropped_chunk
branch
from
178e7c8
to
bcc35b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal function would only remove chunk_constraints that are part of dimension constraints. This patch changes it to remove all constraints of a chunk.
Fixes #6905