Add function to drop the osm chunk #6801
Draft
+259
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konskov
force-pushed
the
drop_osm_chunk_func
branch
from
291efba
to
7bb9c87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6801 +/- ##
==========================================
+ Coverage 80.06% 80.73% +0.66%
==========================================
Files 190 194 +4
Lines 37181 36775 -406
Branches 9450 9639 +189
==========================================
- Hits 29770 29691 -79
- Misses 2997 3174 +177
+ Partials 4414 3910 -504 ☔ View full report in Codecov by Sentry. |
konskov
force-pushed
the
drop_osm_chunk_func
branch
2 times, most recently
from
ff2896d
to
233a516
Compare
gayyappan
reviewed
Apr 4, 2024
| /* do not drop any chunk dependencies */ | ||
| ts_chunk_drop(ch, DROP_RESTRICT, LOG); | ||
| /* reset hypertable OSM status */ | ||
| ht->fd.status = HYPERTABLE_STATUS_DEFAULT; |
There was a problem hiding this comment.
should this be done via hypertable_update_status_osm call instead of ts_hypertable_update()?
There was a problem hiding this comment.
yes, using hypertable_update_status_osm would probably be a better option as it takes the proper locks for updating the timescaledb_catalog.hypertable row
konskov
force-pushed
the
drop_osm_chunk_func
branch
from
233a516
to
f49f2e9
Compare
konskov
force-pushed
the
drop_osm_chunk_func
branch
from
f49f2e9
to
fc86ea0
Compare
Comment on lines
+80
to
+83
| CREATE OR REPLACE FUNCTION _timescaledb_functions.drop_osm_table_chunk( | ||
| hypertable REGCLASS, | ||
| chunk REGCLASS) | ||
| RETURNS BOOL AS '@MODULE_PATHNAME@', 'ts_chunk_drop_osm_table_chunk' LANGUAGE C VOLATILE; |
There was a problem hiding this comment.
Why not pass only the chunk regclass to this API??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires PR 6815