Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for OSM runtime chunk exclusion #6688

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

konskov
Copy link
Contributor

@konskov konskov commented Feb 22, 2024

No description provided.

@konskov konskov self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 14.70588% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 80.87%. Comparing base (59f50f2) to head (b8c9702).
Report is 59 commits behind head on main.

Files Patch % Lines
src/nodes/chunk_append/exec.c 6.25% 14 Missing and 1 partial ⚠️
.../constraint_aware_append/constraint_aware_append.c 7.69% 11 Missing and 1 partial ⚠️
src/osm_callbacks.c 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6688      +/-   ##
==========================================
+ Coverage   80.06%   80.87%   +0.80%     
==========================================
  Files         190      191       +1     
  Lines       37181    36371     -810     
  Branches     9450     9440      -10     
==========================================
- Hits        29770    29414     -356     
- Misses       2997     3199     +202     
+ Partials     4414     3758     -656     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@konskov konskov force-pushed the konskov/runtime_exclusion_tsdb_side branch from 2bf2095 to 1b490d7 Compare February 22, 2024 13:13
@konskov konskov force-pushed the konskov/runtime_exclusion_tsdb_side branch from 1b490d7 to b8c9702 Compare March 6, 2024 16:33
@@ -256,6 +263,43 @@ do_startup_exclusion(ChunkAppendState *state)
}
restrictinfos = constify_restrictinfos(&root, restrictinfos);

#if PG14_GE
// this is where we run the OSM chunk exclusion code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code should be moved inside can_exclude_chunk
can_exclude_chunk will do the usual predicate_refuted_by for the chunk AND if it is an OSM chunk, it will execute this additional logic.

Then all callers of can_exclude_chunk will do the right thing.
WDYT @zilder @konskov

@zilder
Copy link
Contributor

zilder commented Apr 15, 2024

I think this is the old version, it looks like the latest version is this one:
https://github.com/konskov/timescaledb/tree/konskov/runtime_exclusion_tsdb_side_new_approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants